Use ApiUnitTest for storage API tests (storage_api_unittest and storage_frontend_unittest).

Use ApiUnitTest for storage API tests (storage_api_unittest and storage_frontend_unittest).

Make these tests and settings_quota_unittest run in extensions_unittests.

Move a test that depends on sync (not available in the extensions module) to settings_sync_unittest.

Depends on previous CL: https://chromiumcodereview.appspot.com/461273003/

BUG=397164
Committed: https://crrev.com/2246d84a3a1cb870570d2652d82c27f99be778f7
Cr-Commit-Position: refs/heads/master@{#292412}

[Yoyo Zhou, 2014-08-15 22:42:22]

rockot: please review
kalman: FYI, the only thing I'm uncertain about is moving the sync-related test
from Frontend to Sync tests. It seems okay there, or it could be its own file.

[not at google - send to devlin, 2014-08-15 22:58:56]

I think it's fine

[Ken Rockot(use gerrit already), 2014-08-17 21:28:28]

lgtm

https://codereview.chromium.org/472343003/diff/40001/extensions/browser/api/s...
File extensions/browser/api/storage/settings_test_util.cc (right):

https://codereview.chromium.org/472343003/diff/40001/extensions/browser/api/s...
extensions/browser/api/storage/settings_test_util.cc:31: for (int i = 0; i <
1000; ++i) {
I hate to be that guy, but this isn't a megabyte!

[Yoyo Zhou, 2014-08-17 21:45:28]

https://codereview.chromium.org/472343003/diff/40001/extensions/browser/api/s...
File extensions/browser/api/storage/settings_test_util.cc (right):

https://codereview.chromium.org/472343003/diff/40001/extensions/browser/api/s...
extensions/browser/api/storage/settings_test_util.cc:31: for (int i = 0; i <
1000; ++i) {
On 2014/08/17 21:28:27, Ken Rockot (ooo aug 18-26) wrote:
> I hate to be that guy, but this isn't a megabyte!

I noticed too!

[not at google - send to devlin, 2014-08-18 20:01:24]

https://codereview.chromium.org/472343003/diff/40001/extensions/browser/api/s...
File extensions/browser/api/storage/settings_test_util.cc (right):

https://codereview.chromium.org/472343003/diff/40001/extensions/browser/api/s...
extensions/browser/api/storage/settings_test_util.cc:31: for (int i = 0; i <
1000; ++i) {
On 2014/08/17 21:45:28, Yoyo Zhou wrote:
> On 2014/08/17 21:28:27, Ken Rockot (ooo aug 18-26) wrote:
> > I hate to be that guy, but this isn't a megabyte!
> 
> I noticed too!

My bad. It's half way between a real and a bizarro megabyte. I guess I was
compromising without realising it.

[Yoyo Zhou, 2014-08-28 02:43:36]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-08-28 02:44:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoz@chromium.org/472343003/60001

[commit-bot: I haz the power, 2014-08-28 03:48:14]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[commit-bot: I haz the power, 2014-08-28 05:43:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 05:43:43]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yoyo Zhou, 2014-08-28 17:34:11]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-08-28 17:35:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoz@chromium.org/472343003/60001

[commit-bot: I haz the power, 2014-08-28 18:19:19]

Committed patchset #2 (id:60001) as 41a015ec3b5828ad173e2b7ad21df9193755b959

[commit-bot: I haz the power, 2014-09-10 03:00:32]

Patchset 2 (id:??) landed as
https://crrev.com/2246d84a3a1cb870570d2652d82c27f99be778f7
Cr-Commit-Position: refs/heads/master@{#292412}