Issue 472213002: Mark some files/targets as compiled only when their associated feature is enabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 472213002: Mark some files/targets as compiled only when their associated feature is enabled. (Closed)

Created:
6 years, 4 months ago by Lei Zhang

Modified:
6 years, 4 months ago

Reviewers:
tommycli

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Mark some files/targets as compiled only when their associated feature is enabled. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290046

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -56 lines)			Patch
M	chrome/BUILD.gn	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/BUILD.gn	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	6 chunks	+38 lines, -35 lines	0 comments	Download
M	chrome/chrome_resources.gyp	View	2 chunks	+20 lines, -16 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/472213002/1

6 years, 4 months ago (2014-08-15 19:18:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 290046