Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 472203002: Cast streaming logging: Log additional stats for the GetStats() API. (Closed)

Created:
6 years, 4 months ago by imcheng
Modified:
6 years, 4 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@REAL-NEW-MASTER
Project:
chromium
Visibility:
Public.

Description

Cast streaming logging: Log additional stats for the GetStats() API. * Total frames captured * Total frames dropped * Total frames late * Total packet count * Total packet retransmission * Total packet retransmission rejected BUG=403921 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289879

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -33 lines) Patch
M media/cast/logging/stats_event_subscriber.h View 6 chunks +39 lines, -8 lines 0 comments Download
M media/cast/logging/stats_event_subscriber.cc View 11 chunks +70 lines, -13 lines 0 comments Download
M media/cast/logging/stats_event_subscriber_unittest.cc View 10 chunks +79 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
imcheng
PTAL
6 years, 4 months ago (2014-08-15 01:21:17 UTC) #1
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 4 months ago (2014-08-15 01:52:37 UTC) #2
Alpha Left Google
lgtm
6 years, 4 months ago (2014-08-15 01:52:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/472203002/1
6 years, 4 months ago (2014-08-15 01:58:01 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-15 06:02:11 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 15:51:41 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (1) as 289879

Powered by Google App Engine
This is Rietveld 408576698