Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 472183002: Chromecast: Adds WebUI stubs for cast shell. (Closed)

Created:
6 years, 4 months ago by gunsch
Modified:
6 years, 4 months ago
Reviewers:
lcwu1, byungchul
CC:
chromium-reviews, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Chromecast: Adds WebUI stubs for cast shell. Chromecast products provide different WebUIs for pages to display. This provides an appropriate initialization hook. R=byungchul@chromium.org,lcwu@chromium.org BUG=336640 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289916

Patch Set 1 #

Patch Set 2 : rebase (since devtools added) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M chromecast/chromecast.gyp View 1 3 chunks +3 lines, -0 lines 0 comments Download
M chromecast/shell/browser/cast_browser_main_parts.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download
A chromecast/shell/browser/webui/webui_cast.h View 1 chunk +18 lines, -0 lines 0 comments Download
A + chromecast/shell/browser/webui/webui_cast_simple.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gunsch
6 years, 4 months ago (2014-08-15 00:07:27 UTC) #1
byungchul
lgtm
6 years, 4 months ago (2014-08-15 00:14:55 UTC) #2
lcwu1
lgtm
6 years, 4 months ago (2014-08-15 00:28:01 UTC) #3
gunsch
The CQ bit was checked by gunsch@chromium.org
6 years, 4 months ago (2014-08-15 06:21:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gunsch@chromium.org/472183002/20001
6 years, 4 months ago (2014-08-15 06:23:20 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 16:39:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 289916

Powered by Google App Engine
This is Rietveld 408576698