Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 472153002: Remove unused SkGlyphCache::VisitAllCaches. (Closed)

Created:
6 years, 4 months ago by bungeman-skia
Modified:
6 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Project:
skia
Visibility:
Public.

Description

Remove unused SkGlyphCache::VisitAllCaches. Committed: https://skia.googlesource.com/skia/+/8a986721926f77aba3772acb5d1c575072acd05c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M src/core/SkGlyphCache.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/core/SkGlyphCache.cpp View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bungeman-skia
Maybe this was intended to be used for something at some point? In any event, ...
6 years, 4 months ago (2014-08-14 22:48:41 UTC) #1
bungeman-skia
The CQ bit was checked by bungeman@google.com
6 years, 4 months ago (2014-08-14 22:48:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/472153002/1
6 years, 4 months ago (2014-08-14 22:49:36 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-14 22:49:37 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 04:49:38 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 4 months ago (2014-08-15 04:49:43 UTC) #6
reed1
lgtm
6 years, 4 months ago (2014-08-15 14:16:25 UTC) #7
reed1
The CQ bit was checked by reed@google.com
6 years, 4 months ago (2014-08-15 14:16:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/472153002/1
6 years, 4 months ago (2014-08-15 14:17:13 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 14:57:32 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (1) as 8a986721926f77aba3772acb5d1c575072acd05c

Powered by Google App Engine
This is Rietveld 408576698