Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 47213009: Add callbacks to register EGL bindings from Ozone (Closed)

Created:
7 years, 1 month ago by dnicoara
Modified:
7 years, 1 month ago
Reviewers:
rjkroege, piman
CC:
chromium-reviews, rjkroege, ozone-dev_chromium.org
Visibility:
Public.

Description

Add callbacks to register EGL bindings from Ozone Ozone needs to provide a custom way to load EGL and GLES2 bindings. Since Ozone lives in ui/gfx/ozone it cannot have dependencies to ui/gl to register the libraries. This patch adds to callbacks to Ozone's LoadEGLGLES2Bindings function such that when performing GL bindings initialization ui/gl will provide the callbacks to register the bindings. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -8 lines) Patch
M ui/gfx/ozone/impl/file_surface_factory_ozone.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/ozone/impl/file_surface_factory_ozone.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/ozone/impl/software_surface_factory_ozone.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/ozone/impl/software_surface_factory_ozone.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/ozone/surface_factory_ozone.h View 3 chunks +12 lines, -2 lines 0 comments Download
M ui/gfx/ozone/surface_factory_ozone.cc View 1 chunk +5 lines, -1 line 0 comments Download
M ui/gl/gl_implementation_ozone.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
dnicoara
7 years, 1 month ago (2013-10-28 20:10:31 UTC) #1
rjkroege
lgtm Proviso: this is a bit un-nice. If this is the only case that needs ...
7 years, 1 month ago (2013-10-29 16:02:42 UTC) #2
kalyank
On 2013/10/29 16:02:42, rjkroege wrote: > lgtm > > Proviso: this is a bit un-nice. ...
7 years, 1 month ago (2013-10-29 16:14:15 UTC) #3
dnicoara
Adding piman@ for ui/gl owners.
7 years, 1 month ago (2013-10-29 18:36:06 UTC) #4
piman
LGTM, though I feel an interface rather than 2 callbacks would be nicer.
7 years, 1 month ago (2013-10-29 20:52:22 UTC) #5
dnicoara
On 2013/10/29 20:52:22, piman wrote: > LGTM, though I feel an interface rather than 2 ...
7 years, 1 month ago (2013-10-29 21:23:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/47213009/1
7 years, 1 month ago (2013-10-30 12:35:22 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=94985
7 years, 1 month ago (2013-10-30 15:27:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/47213009/1
7 years, 1 month ago (2013-10-30 15:33:33 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-10-30 19:23:33 UTC) #10
Message was sent while issue was closed.
Change committed as 231893

Powered by Google App Engine
This is Rietveld 408576698