Issue 472053004: Extensions: Do not depend on device_serial_mojo target when extensions are turned off.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 472053004: Extensions: Do not depend on device_serial_mojo target when extensions are turned off. (Closed)

Created:
6 years, 4 months ago by Lei Zhang

Modified:
6 years, 4 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Extensions: Do not depend on device_serial_mojo target when extensions are turned off. BUG=334407 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290121

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -8 lines)			Patch
M	extensions/BUILD.gn	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	extensions/extensions.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	extensions/extensions_resources.gyp	View	2 chunks	+7 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/472053004/1

6 years, 4 months ago (2014-08-15 23:28:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 290121