Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 472053002: Rename GeolocationProviderImpl unittest file to match what it tests. (Closed)

Created:
6 years, 4 months ago by Michael van Ouwerkerk
Modified:
6 years, 4 months ago
Reviewers:
timvolodine
CC:
chromium-reviews, darin-cc_chromium.org, jam, Michael van Ouwerkerk
Project:
chromium
Visibility:
Public.

Description

Rename GeolocationProviderImpl unittest file to match what it tests. It tests geolocation_provider_impl.{h,cc} Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289836

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -258 lines) Patch
A + content/browser/geolocation/geolocation_provider_impl_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D content/browser/geolocation/geolocation_provider_unittest.cc View 1 chunk +0 lines, -258 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Michael van Ouwerkerk
Tim, please take a look :-)
6 years, 4 months ago (2014-08-14 17:37:57 UTC) #1
timvolodine
lgtm
6 years, 4 months ago (2014-08-14 17:48:46 UTC) #2
Michael van Ouwerkerk
The CQ bit was checked by mvanouwerkerk@chromium.org
6 years, 4 months ago (2014-08-14 17:53:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/472053002/1
6 years, 4 months ago (2014-08-14 17:55:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-15 02:01:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 03:29:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/2067)
6 years, 4 months ago (2014-08-15 03:29:58 UTC) #7
Michael van Ouwerkerk
The CQ bit was checked by mvanouwerkerk@chromium.org
6 years, 4 months ago (2014-08-15 06:58:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/472053002/1
6 years, 4 months ago (2014-08-15 06:59:41 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 09:43:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (1) as 289836

Powered by Google App Engine
This is Rietveld 408576698