Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Unified Diff: Source/core/inspector/ConsoleMessage.h

Issue 472023002: [DevTools] ConsoleAPI messages pass through frame console (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: PassRefPtr<ConsoleMessage> -> PassRefPtrWillBeRawPtr<ConsoleMessage> Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/FrameConsole.cpp ('k') | Source/core/inspector/ConsoleMessage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/ConsoleMessage.h
diff --git a/Source/core/inspector/ConsoleMessage.h b/Source/core/inspector/ConsoleMessage.h
index bb5383932f7bcf1dd04b18740ecbe9a668b5202a..ef49aec257aaa469df27b4443c6d749bfba45b1d 100644
--- a/Source/core/inspector/ConsoleMessage.h
+++ b/Source/core/inspector/ConsoleMessage.h
@@ -7,6 +7,7 @@
#include "bindings/core/v8/ScriptState.h"
#include "core/frame/ConsoleTypes.h"
+#include "core/inspector/ConsoleAPITypes.h"
#include "core/inspector/ScriptCallStack.h"
#include "platform/heap/Handle.h"
#include "wtf/Forward.h"
@@ -16,6 +17,7 @@
namespace blink {
+class ScriptArguments;
class ScriptCallStack;
class ScriptState;
class WorkerGlobalScopeProxy;
@@ -26,41 +28,45 @@ public:
{
return adoptRefWillBeNoop(new ConsoleMessage(source, level, message, url, lineNumber, columnNumber));
}
-
~ConsoleMessage();
+ MessageType type() const;
+ void setType(MessageType);
+ const String& url() const;
+ void setURL(const String&);
+ unsigned lineNumber() const;
+ void setLineNumber(unsigned);
PassRefPtrWillBeRawPtr<ScriptCallStack> callStack() const;
void setCallStack(PassRefPtrWillBeRawPtr<ScriptCallStack>);
ScriptState* scriptState() const;
void setScriptState(ScriptState*);
+ PassRefPtr<ScriptArguments> scriptArguments() const;
+ void setScriptArguments(PassRefPtr<ScriptArguments>);
unsigned long requestIdentifier() const;
void setRequestIdentifier(unsigned long);
- const String& url() const;
- void setURL(const String&);
- unsigned lineNumber() const;
- void setLineNumber(unsigned);
+ WorkerGlobalScopeProxy* workerId() { return m_workerProxy; }
+ void setWorkerId(WorkerGlobalScopeProxy* proxy) { m_workerProxy = proxy; }
MessageSource source() const;
MessageLevel level() const;
const String& message() const;
unsigned columnNumber() const;
- void setWorkerId(WorkerGlobalScopeProxy* proxy) { m_workerProxy = proxy; }
- WorkerGlobalScopeProxy* workerId() { return m_workerProxy; }
void trace(Visitor*);
private:
- ConsoleMessage();
ConsoleMessage(MessageSource, MessageLevel, const String& message, const String& url = String(), unsigned lineNumber = 0, unsigned columnNumber = 0);
MessageSource m_source;
MessageLevel m_level;
+ MessageType m_type;
String m_message;
String m_url;
unsigned m_lineNumber;
unsigned m_columnNumber;
RefPtrWillBeMember<ScriptCallStack> m_callStack;
- ScriptState* m_scriptState;
+ OwnPtr<ScriptStateProtectingContext> m_scriptState;
+ RefPtr<ScriptArguments> m_scriptArguments;
unsigned long m_requestIdentifier;
WorkerGlobalScopeProxy* m_workerProxy;
};
« no previous file with comments | « Source/core/frame/FrameConsole.cpp ('k') | Source/core/inspector/ConsoleMessage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698