Source/core/inspector/InspectorConsoleMessage.h - Issue 472023002: [DevTools] ConsoleAPI messages pass through frame console

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorConsoleMessage.h

Issue 472023002: [DevTools] ConsoleAPI messages pass through frame console (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/inspector/ConsoleMessage.h ('K') | « Source/core/inspector/InspectorConsoleAgent.cpp ('k') | Source/core/inspector/InspectorDebuggerAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorConsoleMessage.h

diff --git a/Source/core/inspector/InspectorConsoleMessage.h b/Source/core/inspector/InspectorConsoleMessage.h

index a8118f42478a3d743218c50df004444ed72afc09..5d9cc524e898c74e90648cfa41c615acfc5c2593 100644

--- a/Source/core/inspector/InspectorConsoleMessage.h

+++ b/Source/core/inspector/InspectorConsoleMessage.h

@@ -54,7 +54,7 @@ public:

InspectorConsoleMessage(MessageSource, MessageType, MessageLevel, const String& message);

InspectorConsoleMessage(bool shouldGenerateCallStack, MessageSource, MessageType, MessageLevel, const String& message, const String& url, unsigned line, unsigned column, ScriptState*, unsigned long requestIdentifier);

InspectorConsoleMessage(MessageSource, MessageType, MessageLevel, const String& message, PassRefPtrWillBeRawPtr<ScriptCallStack>, unsigned long requestIdentifier);

- InspectorConsoleMessage(MessageSource, MessageType, MessageLevel, const String& message, PassRefPtrWillBeRawPtr<ScriptArguments>, ScriptState*, unsigned long requestIdentifier);

+ InspectorConsoleMessage(MessageSource, MessageType, MessageLevel, const String& message, PassRefPtrWillBeRawPtr<ScriptArguments>, ScriptState*, unsigned long requestIdentifier = 0);

vsevik 2014/08/19 08:04:55 We should delete requestIdentifier param from this

kozyatinskiy1 2014/08/19 08:26:26 Done.

~InspectorConsoleMessage();

void addToFrontend(InspectorFrontend::Console*, InjectedScriptManager*, bool generatePreview);

« Source/core/inspector/ConsoleMessage.h ('K') | « Source/core/inspector/InspectorConsoleAgent.cpp ('k') | Source/core/inspector/InspectorDebuggerAgent.h » ('j') | no next file with comments »