Issue 471973003: Make the user manager UI not permit guest mode when preferences dictate

Issue 471973003: Make the user manager UI not permit guest mode when preferences dictate (Closed)

Created:
6 years, 4 months ago by Mike Lerman

Modified:
6 years, 4 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Make the user manager UI not permit guest mode when preferences dictate (either ones blocking guest mode in particular or guest mode). Follow-up to the CL http://codereview.chromium.org/385073008 CL is currently blocked on crbug.com/394413. No more, it landed! BUG=306322 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290069

Patch Set 1 #

Total comments: 1

Patch Set 2 : Let there be braces #

Patch Set 3 : Rebase #

Patch Set 4 : Only enforce BrowserGuest policy #

Patch Set 5 : Remove an unneeded header #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -6 lines)			Patch
	M	chrome/browser/resources/user_manager/user_manager.js	View		2 chunks	+9 lines, -1 line	0 comments	Download
	M	chrome/browser/ui/webui/signin/user_manager_screen_handler.cc	View	1 2 3 4	4 chunks	+18 lines, -5 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Mike Lerman

Hi Nikita, I had to break apart the CL that is listed in the description ...

6 years, 4 months ago (2014-08-14 15:06:09 UTC) #1

Nikita (slow)

lgtm https://codereview.chromium.org/471973003/diff/1/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc File chrome/browser/ui/webui/signin/user_manager_screen_handler.cc (right): https://codereview.chromium.org/471973003/diff/1/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc#newcode153 chrome/browser/ui/webui/signin/user_manager_screen_handler.cc:153: return false; nit: Add {}

6 years, 4 months ago (2014-08-14 15:53:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/471973003/20001

6 years, 4 months ago (2014-08-15 17:42:19 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/471973003/80001

6 years, 4 months ago (2014-08-15 20:38:33 UTC) #7

commit-bot: I haz the power

6 years, 4 months ago (2014-08-16 00:37:50 UTC) #8

Message was sent while issue was closed.

Committed patchset #5 (80001) as 290069

Expand Messages | Collapse Messages