src/api.cc - Issue 471923002: Purge unused internalized string accessors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 471923002: Purge unused internalized string accessors. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 4a6345910f978176c56c6476f232dd0e58e496c8..64672bd9ce276820dcd77218bd5017891f35e2ce 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -3296,7 +3296,8 @@ Local<String> v8::Object::ObjectProtoToString() {

return v8::String::NewFromUtf8(isolate, "[object ]");

} else {

i::Handle<i::String> class_name = i::Handle<i::String>::cast(name);

- if (class_name->IsOneByteEqualTo(STATIC_ASCII_VECTOR("Arguments"))) {

+ if (i::String::Equals(class_name,

+ i_isolate->factory()->Arguments_string())) {

return v8::String::NewFromUtf8(isolate, "[object Object]");

} else {

const char* prefix = "[object ";

« no previous file with comments | « include/v8.h ('k') | src/arm/full-codegen-arm.cc » ('j') | no next file with comments »