Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 471903002: Video Player: Disables cast feature by default (Closed)

Created:
6 years, 4 months ago by yoshiki
Modified:
6 years, 4 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Video Player: Disables cast feature by default The feature will work only when the flag is on. BUG=305511 TEST=Confirms the cast icon doesn't appear when the flag is off. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289621

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed the comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M ui/file_manager/video_player/js/cast/caster.js View 1 chunk +18 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yoshiki
@hirono, PTAL. Thanks.
6 years, 4 months ago (2014-08-14 09:22:47 UTC) #1
hirono
lgtm with a nit? https://codereview.chromium.org/471903002/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc File chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc (right): https://codereview.chromium.org/471903002/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc#newcode905 chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc:905: base::CommandLine* command_line = base::CommandLine::ForCurrentProcess(); nit: ...
6 years, 4 months ago (2014-08-14 09:39:19 UTC) #2
hirono
On 2014/08/14 09:39:19, hirono wrote: > lgtm with a nit? > > https://codereview.chromium.org/471903002/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc > File ...
6 years, 4 months ago (2014-08-14 09:40:27 UTC) #3
yoshiki
Thanks. https://codereview.chromium.org/471903002/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc File chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc (right): https://codereview.chromium.org/471903002/diff/20001/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc#newcode905 chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc:905: base::CommandLine* command_line = base::CommandLine::ForCurrentProcess(); On 2014/08/14 09:39:18, hirono ...
6 years, 4 months ago (2014-08-14 10:21:14 UTC) #4
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 4 months ago (2014-08-14 10:21:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/471903002/40001
6 years, 4 months ago (2014-08-14 10:24:41 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-14 15:47:33 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 17:03:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (40001) as 289621

Powered by Google App Engine
This is Rietveld 408576698