Issue 471893003: Parse shmmax as a uint64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 471893003: Parse shmmax as a uint64 (Closed)

Created:
6 years, 4 months ago by brettw

Modified:
6 years, 4 months ago

Reviewers:
jamesr

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Parse shmmax as a uint64 A recent Linux kernel change changed this to a number larger than 63 bits which causes us to compute 0 size. I kept the size_t overflow check for cases where size_t is 32-bits. BUG=403869 R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289903

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	base/sys_info_linux.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

brettw

6 years, 4 months ago (2014-08-15 16:27:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 289903 (presubmit successful).