Source/core/html/HTMLSelectElement.cpp - Issue 471803003: Adjust autofilled property for <search> input and <select> elements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLSelectElement.cpp

Issue 471803003: Adjust autofilled property for <search> input and <select> elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update code as per review comments. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/input-autofilled.html ('K') | « LayoutTests/fast/forms/textarea/edit-autofilled-text-expected.txt ('k') | Source/core/html/shadow/TextControlInnerElements.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLSelectElement.cpp

diff --git a/Source/core/html/HTMLSelectElement.cpp b/Source/core/html/HTMLSelectElement.cpp

index 2a353bb472d393b91cb46404208258329310b9c8..94b52ccff26e9496227f6f4092eb0aa47477a1c9 100644

--- a/Source/core/html/HTMLSelectElement.cpp

+++ b/Source/core/html/HTMLSelectElement.cpp

@@ -914,6 +914,8 @@ void HTMLSelectElement::optionRemoved(const HTMLOptionElement& option)

m_activeSelectionAnchorIndex--;

if (listIndex <= m_activeSelectionEndIndex)

m_activeSelectionEndIndex--;

+ if (listIndex == selectedIndex())

+ setAutofilled(false);

}

void HTMLSelectElement::selectOption(int optionIndex, SelectOptionFlags flags)