Issue 471803002: athena: Fix a use-after-free case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 471803002: athena: Fix a use-after-free case. (Closed)

Created:
6 years, 4 months ago by sadrul

Modified:
6 years, 4 months ago

Reviewers:
oshima, mfomitchev

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

athena: Fix a use-after-free case. |split_view_controller_| depends on |mru_window_tracker_|. So destroy them in the correct order to avoid the use-after-free when destroying the window manager. BUG=none TBR=mfomitchev@chromium.org, oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289464

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	athena/wm/window_manager_impl.cc	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

Committed patchset #1 manually as 289464 (presubmit successful).

6 years, 4 months ago (2014-08-14 05:15:06 UTC) #2

mfomitchev

6 years, 4 months ago (2014-08-14 13:10:02 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/471803002/diff/1/athena/wm/window_manager_imp...
File athena/wm/window_manager_impl.cc (right):

https://codereview.chromium.org/471803002/diff/1/athena/wm/window_manager_imp...
athena/wm/window_manager_impl.cc:138: split_view_controller_.reset();
Ugh. Thanks. Sorry, I should've done the Asan build myself.
Should we destroy the bezel_controller_ explicitly here as well since it holds a
raw pointer to container_ and to split_view_controller?

Expand Messages | Collapse Messages