Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 471763009: Update the Website Settings options page when a Content Setting is used. (Closed)

Created:
6 years, 4 months ago by Daniel Nishi
Modified:
6 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, scheib, dbeam+watch-options_chromium.org, markusheintz_
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update the Website Settings options page when a Content Setting is used. BUG=407342 Committed: https://crrev.com/7a32920fbe0a3c05a17cbf1663636b56356a2611 Cr-Commit-Position: refs/heads/master@{#291931}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M chrome/browser/content_settings/content_settings_observer.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/website_settings_handler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/website_settings_handler.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Daniel Nishi
dhnishi@chromium.org changed reviewers: + bauerb@chromium.org
6 years, 4 months ago (2014-08-25 21:25:40 UTC) #1
Daniel Nishi
bauerb: PTAL when you get a moment.
6 years, 4 months ago (2014-08-25 21:25:40 UTC) #2
Bernhard Bauer
lgtm
6 years, 3 months ago (2014-08-26 07:52:38 UTC) #3
Daniel Nishi
The CQ bit was checked by dhnishi@chromium.org
6 years, 3 months ago (2014-08-26 16:57:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dhnishi@chromium.org/471763009/1
6 years, 3 months ago (2014-08-26 16:58:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as e30ea658b34dcdadd4cf471a6602d0105f3ed6b4
6 years, 3 months ago (2014-08-26 17:54:12 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:43:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a32920fbe0a3c05a17cbf1663636b56356a2611
Cr-Commit-Position: refs/heads/master@{#291931}

Powered by Google App Engine
This is Rietveld 408576698