Nicely handle OnBeforeUnloads with guest and lock mode.

chrome/browser/profiles/profile_window.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_window.h"
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 241 matching lines @@
           placeholder_avatar_index)),
       base::Bind(&OpenBrowserWindowForProfile,
                  callback,
                  true,
                  true,
                  desktop_type),
       std::string());
   ProfileMetrics::LogProfileAddNewUser(metric);
 }
 
+void GuestBrowserCloseSuccess(const size_t profile_index) {

[noms (inactive), 2014/08/26 20:17:32]

I don't think you need the profile_index as an argument if you're not using it.
Also, can you just use base::Bind(&chrome::ShowUserManager) instead? I don't
think anyone else calls GuestBrowserCloseSuccess...

If not, ShowUserManagerMaybeWithTutorial(null) is also an option. I don't think
you need to define this function just to call ShowUserManager

[Mike Lerman, 2014/08/27 14:11:38]

The on_close_confirmed parameter of CloseAllBrowsersWithProfile needs to take a
function of signature void(size_t), which is necessary for
LockBrowserCloseSuccess. Neither of the method you've mentioned that will
directly create the UserManager have that signature, so I think I need to make a
method here that matches.

+  chrome::ShowUserManager(base::FilePath());
+}
+
 void CloseGuestProfileWindows() {
   ProfileManager* profile_manager = g_browser_process->profile_manager();
   Profile* profile = profile_manager->GetProfileByPath(
       ProfileManager::GetGuestProfilePath());
 
   if (profile) {
-    BrowserList::CloseAllBrowsersWithProfile(profile);
+    BrowserList::CloseAllBrowsersWithProfile(profile,
+        base::Bind(&GuestBrowserCloseSuccess),
+        base::Bind(&BrowserList::DoNothing));
   }
 }
 
+void LockBrowserCloseSuccess(const size_t profile_index) {
+  ProfileInfoCache& cache =
+      g_browser_process->profile_manager()->GetProfileInfoCache();
+  DCHECK_LT(profile_index, cache.GetNumberOfProfiles());
+
+  cache.SetProfileSigninRequiredAtIndex(profile_index, true);
+  chrome::ShowUserManager(cache.GetPathOfProfileAtIndex(profile_index));
+}
+
 void LockProfile(Profile* profile) {
   DCHECK(profile);
-  ProfileInfoCache& cache =
-      g_browser_process->profile_manager()->GetProfileInfoCache();
-
-  size_t index = cache.GetIndexOfProfileWithPath(profile->GetPath());
-  cache.SetProfileSigninRequiredAtIndex(index, true);
-  chrome::ShowUserManager(profile->GetPath());
-  BrowserList::CloseAllBrowsersWithProfile(profile);
+  if (profile) {
+    BrowserList::CloseAllBrowsersWithProfile(profile,
+        base::Bind(&LockBrowserCloseSuccess),
+        base::Bind(&BrowserList::DoNothing));
+  }
 }
 
 void CreateGuestProfileForUserManager(
     const base::FilePath& profile_path_to_focus,
     profiles::UserManagerTutorialMode tutorial_mode,
     const base::Callback<void(Profile*, const std::string&)>& callback) {
   // Create the guest profile, if necessary, and open the User Manager
   // from the guest profile.
   g_browser_process->profile_manager()->CreateProfileAsync(
       ProfileManager::GetGuestProfilePath(),
@@ skipping 84 matching lines @@
     case BrowserWindow::AVATAR_BUBBLE_MODE_SHOW_ERROR:
       *bubble_view_mode = BUBBLE_VIEW_MODE_PROFILE_CHOOSER;
       *tutorial_mode = TUTORIAL_MODE_SHOW_ERROR;
       return;
     default:
       *bubble_view_mode = profiles::BUBBLE_VIEW_MODE_PROFILE_CHOOSER;
   }
 }
 
 }  // namespace profiles