Nicely handle OnBeforeUnloads with guest and lock mode.

chrome/browser/ui/browser_list.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_LIST_H_
 #define CHROME_BROWSER_UI_BROWSER_LIST_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/lazy_instance.h"
 #include "base/observer_list.h"
 #include "chrome/browser/ui/host_desktop.h"
 
 class Browser;
 class Profile;
 
 namespace chrome {
 class BrowserListObserver;
 }
 
+namespace base {
+class FilePath;
+}
+
 // Maintains a list of Browser objects present in a given HostDesktop (see
 // HostDesktopType).
 class BrowserList {
  public:
   typedef std::vector<Browser*> BrowserVector;
   typedef BrowserVector::const_iterator const_iterator;
   typedef BrowserVector::const_reverse_iterator const_reverse_iterator;
 
   // Returns the last active browser for this list.
   Browser* GetLastActive() const;
@@ skipping 33 matching lines @@
   static void AddObserver(chrome::BrowserListObserver* observer);
   static void RemoveObserver(chrome::BrowserListObserver* observer);
 
   // Called by Browser objects when their window is activated (focused).  This
   // allows us to determine what the last active Browser was on each desktop.
   // Note: This only takes effect on the appropriate browser list as determined
   // by |browser->host_desktop_type()|.
   static void SetLastActive(Browser* browser);
 
   // Closes all browsers for |profile| across all desktops.
+  // TODO(mlerman): Move the Profile Deletion flow to use the overloaded
+  // version of this method with a callback, then remove this method.
   static void CloseAllBrowsersWithProfile(Profile* profile);
 
+  // Closes all browsers for |profile| across all desktops. This method is
+  // called once and will defer to TryToCloseBrowserList to handle each
+  // OnBeforeUnload event. If all OnBeforeUnload events are confirmed,

[Peter Kasting, 2014/08/29 21:30:25]

Nit: Second sentence might be clearer as:

  Uses TryToCloseBrowserList() to do the actual closing and trigger any
OnBeforeUnload events.

[Mike Lerman, 2014/09/02 15:15:41]

Done.

+  // |on_close_success| is called.
+  static void CloseAllBrowsersWithProfile(
+      Profile* profile,
+      const base::Callback<void(const base::FilePath&)>& on_close_success);
+
   // Returns true if at least one incognito session is active across all
   // desktops.
   static bool IsOffTheRecordSessionActive();
 
   // Returns true if at least one incognito session is active for |profile|
   // across all desktops.
   static bool IsOffTheRecordSessionActiveForProfile(Profile* profile);
 
  private:
   BrowserList();
   ~BrowserList();
 
   // Helper method to remove a browser instance from a list of browsers
   static void RemoveBrowserFrom(Browser* browser, BrowserVector* browser_list);
 
+  // Attempts to close |browsers_to_close| while respecting OnBeforeUnload
+  // events. If there are no OnBeforeUnload events to be called,
+  // |on_close_confirmed| will be called, with a parameter of |profile_path|.
+  // If at least one unfired OnBeforeUnload event is found, handle it with a
+  // callback to PostBeforeUnloadHandlers, which upon success will recursively
+  // call this method to handle any other OnBeforeUnload events.
+  static void TryToCloseBrowserList(
+      const BrowserVector& browsers_to_close,
+      const base::Callback<void(const base::FilePath&)>& on_close_success,
+      const base::FilePath& profile_path);
+
+  // Called after handling an OnBeforeUnload event. If |tab_close_confirmed| is
+  // true, call |TryToCloseBrowserList|, passing the parameters

[Peter Kasting, 2014/08/29 21:30:26]

Nit: call |TryToCloseBrowserList| -> calls TryToCloseBrowserList()

[Mike Lerman, 2014/09/02 15:15:41]

Done.

+  // |browsers_to_close|, |on_close_confirmed|, and |profile_path|. Otherwise,
+  // reset all the OnBeforeUnload event handlers and processing ends.

[Peter Kasting, 2014/08/29 21:30:25]

Nit: reset -> resets; remove "and processing ends".

[Mike Lerman, 2014/09/02 15:15:40]

Done.

+  static void PostBeforeUnloadHandlers(
+      const BrowserVector& browsers_to_close,
+      const base::Callback<void(const base::FilePath&)>& on_close_success,
+      const base::FilePath& profile_path,
+      bool tab_close_confirmed);
+
   // A vector of the browsers in this list, in the order they were added.
   BrowserVector browsers_;
   // A vector of the browsers in this list that have been activated, in the
   // reverse order in which they were last activated.
   BrowserVector last_active_browsers_;
 
   // A list of observers which will be notified of every browser addition and
   // removal across all BrowserLists.
   static base::LazyInstance<ObserverList<chrome::BrowserListObserver> >::Leaky
       observers_;
 
   // Nothing fancy, since we only have two HDTs.
   static BrowserList* native_instance_;
   static BrowserList* ash_instance_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserList);
 };
 
 #endif  // CHROME_BROWSER_UI_BROWSER_LIST_H_