Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: media/base/BUILD.gn

Issue 471753002: gn win: Don't add linux-style cflags (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/BUILD.gn
diff --git a/media/base/BUILD.gn b/media/base/BUILD.gn
index fe75b85562be625d6e0da00bb67d6252ae7f530d..6d6ee56879d5fbd7d0935ef19715e4ead7390395 100644
--- a/media/base/BUILD.gn
+++ b/media/base/BUILD.gn
@@ -352,7 +352,9 @@ if (cpu_arch == "x86" || cpu_arch == "x64") {
source_set("media_mmx") {
sources = [ "simd/filter_yuv_mmx.cc" ]
configs += [ "//media:media_config" ]
- cflags = [ "-mmmx" ]
+ if (!is_win) {
+ cflags = [ "-mmmx" ]
scottmg 2014/08/13 23:25:35 This is a bit tricky, 'cflags' is ignored in gyp o
DaleCurtis 2014/08/14 00:23:26 Does msvc require a similar setting?
+ }
}
source_set("media_sse2") {
@@ -362,7 +364,9 @@ if (cpu_arch == "x86" || cpu_arch == "x64") {
"simd/filter_yuv_sse2.cc",
]
configs += [ "//media:media_config" ]
- cflags = [ "-msse2" ]
+ if (!is_win) {
+ cflags = [ "-msse2" ]
+ }
}
import("//third_party/yasm/yasm_assemble.gni")
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698