gn win: Don't add linux-style cflags

gn win: Don't add linux-style cflags

R=dalecurtis@chromium.org,brettw@chromium.org
BUG=354261
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289564

[scottmg, 2014-08-13 23:25:35]

https://codereview.chromium.org/471753002/diff/1/media/base/BUILD.gn
File media/base/BUILD.gn (right):

https://codereview.chromium.org/471753002/diff/1/media/base/BUILD.gn#newcode356
media/base/BUILD.gn:356: cflags = [ "-mmmx" ]
This is a bit tricky, 'cflags' is ignored in gyp on windows so there's likely
other places that will do incorrect conversions like this from .gyp files.

[DaleCurtis, 2014-08-14 00:23:27]

https://codereview.chromium.org/471753002/diff/1/media/base/BUILD.gn
File media/base/BUILD.gn (right):

https://codereview.chromium.org/471753002/diff/1/media/base/BUILD.gn#newcode356
media/base/BUILD.gn:356: cflags = [ "-mmmx" ]
On 2014/08/13 23:25:35, scottmg wrote:
> This is a bit tricky, 'cflags' is ignored in gyp on windows so there's likely
> other places that will do incorrect conversions like this from .gyp files.

Does msvc require a similar setting?

[scottmg, 2014-08-14 00:26:41]

On 2014/08/14 00:23:27, DaleCurtis wrote:
> https://codereview.chromium.org/471753002/diff/1/media/base/BUILD.gn
> File media/base/BUILD.gn (right):
> 
>
https://codereview.chromium.org/471753002/diff/1/media/base/BUILD.gn#newcode356
> media/base/BUILD.gn:356: cflags = [ "-mmmx" ]
> On 2014/08/13 23:25:35, scottmg wrote:
> > This is a bit tricky, 'cflags' is ignored in gyp on windows so there's
likely
> > other places that will do incorrect conversions like this from .gyp files.
> 
> Does msvc require a similar setting?

We default to SSE2 everywhere now, so at least for these two I don't think so.

[DaleCurtis, 2014-08-14 00:28:14]

lgtm then. we should benchmark these methods on sse2 and drop them if the
auto-vectorized c is faster.

[scottmg, 2014-08-14 00:31:09]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-08-14 00:32:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scottmg@chromium.org/471753002/1

[commit-bot: I haz the power, 2014-08-14 14:36:27]

Committed patchset #1 (1) as 289564