Issue 471703003: DevTools: NetworkPanel: fix timeline bar labels vertical alignment.

Issue 471703003: DevTools: NetworkPanel: fix timeline bar labels vertical alignment. (Closed)

Created:
6 years, 4 months ago by eustas

Modified:
6 years, 4 months ago

Reviewers:
vsevik, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: NetworkPanel: fix timeline bar labels vertical alignment. Fix UI regression. See: https://codereview.chromium.org/474453002/ BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180273

Patch Set 1 #

Total comments: 2

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	Source/devtools/front_end/networkLogView.css	View		2 chunks	+2 lines, -1 line	2 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://codereview.chromium.org/471703003/diff/1/Source/devtools/front_end/networkLogView.css File Source/devtools/front_end/networkLogView.css (right): https://codereview.chromium.org/471703003/diff/1/Source/devtools/front_end/networkLogView.css#newcode320 Source/devtools/front_end/networkLogView.css:320: margin-right: -1px; Is this intended?

6 years, 4 months ago (2014-08-14 08:36:17 UTC) #2

eustas

https://codereview.chromium.org/471703003/diff/1/Source/devtools/front_end/networkLogView.css File Source/devtools/front_end/networkLogView.css (right): https://codereview.chromium.org/471703003/diff/1/Source/devtools/front_end/networkLogView.css#newcode320 Source/devtools/front_end/networkLogView.css:320: margin-right: -1px; On 2014/08/14 08:36:17, pfeldman wrote: > Is ...

6 years, 4 months ago (2014-08-14 09:29:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/471703003/1

6 years, 4 months ago (2014-08-14 09:31:49 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...

6 years, 4 months ago (2014-08-14 13:42:32 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (1) as 180273

Expand Messages | Collapse Messages