Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 471693002: Remove unnecessary ifdefs from platform/fonts/FontPlatformData.h (Closed)

Created:
6 years, 4 months ago by eae
Modified:
6 years, 4 months ago
CC:
blink-reviews, Rik, danakj, krit, jamesr, jbroman, pdr., rwlbuis, Stephen Chennney
Project:
blink
Visibility:
Public.

Description

Remove unnecessary ifdefs from platform/fonts/FontPlatformData.h Remove in-class platform ifdefs from platform/fonts/FontPlatformData.h as the entire file is wrapped in a OS(MACOSX) macro. R=leviw@chromium.org, pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180306

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M Source/platform/fonts/FontPlatformData.h View 7 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
eae
6 years, 4 months ago (2014-08-14 15:19:20 UTC) #1
eae
6 years, 4 months ago (2014-08-14 21:13:42 UTC) #2
eae
6 years, 4 months ago (2014-08-14 21:45:14 UTC) #3
leviw_travelin_and_unemployed
lgtm
6 years, 4 months ago (2014-08-14 21:46:15 UTC) #4
eae
Thanks Levi!
6 years, 4 months ago (2014-08-14 21:47:33 UTC) #5
eae
The CQ bit was checked by eae@chromium.org
6 years, 4 months ago (2014-08-14 21:47:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/471693002/1
6 years, 4 months ago (2014-08-14 21:48:30 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 4 months ago (2014-08-14 22:29:13 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 23:16:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/12864)
6 years, 4 months ago (2014-08-14 23:16:51 UTC) #10
eae
The CQ bit was checked by eae@chromium.org
6 years, 4 months ago (2014-08-14 23:37:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/471693002/1
6 years, 4 months ago (2014-08-14 23:39:19 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 4 months ago (2014-08-14 23:53:39 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-14 23:58:22 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/12873)
6 years, 4 months ago (2014-08-14 23:58:23 UTC) #15
eae
6 years, 4 months ago (2014-08-15 00:01:43 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 manually as 180306 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698