Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 471633002: Refactoring code with existing function. (Closed)

Created:
6 years, 4 months ago by JungJik
Modified:
6 years, 4 months ago
Reviewers:
danakj, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Refactoring code with existing function. this patch is for small refactoring the code by using existing function which has the same purpose. (FreeResourcesForTileAndNotifyClientIfTileWasReadyToDraw) Bug=None TEST=cc_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289876

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M cc/resources/tile_manager.cc View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
JungJik
PTAL :)
6 years, 4 months ago (2014-08-14 06:52:00 UTC) #1
danakj
Looks OK to me but I'll let vmpstr review.
6 years, 4 months ago (2014-08-14 17:06:14 UTC) #2
vmpstr
lgtm
6 years, 4 months ago (2014-08-14 23:35:42 UTC) #3
JungJik
On 2014/08/14 23:35:42, vmpstr wrote: > lgtm thanks for lgtm.
6 years, 4 months ago (2014-08-15 01:05:02 UTC) #4
JungJik
The CQ bit was checked by jungjik.lee@samsung.com
6 years, 4 months ago (2014-08-15 01:05:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/471633002/1
6 years, 4 months ago (2014-08-15 01:11:15 UTC) #6
JungJik
The CQ bit was unchecked by jungjik.lee@samsung.com
6 years, 4 months ago (2014-08-15 15:22:40 UTC) #7
JungJik
The CQ bit was checked by jungjik.lee@samsung.com
6 years, 4 months ago (2014-08-15 15:22:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/471633002/1
6 years, 4 months ago (2014-08-15 15:23:14 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 15:42:14 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (1) as 289876

Powered by Google App Engine
This is Rietveld 408576698