Issue 471623003: WebLocalFrameImpl::printPage needs to ensure layout, style, and compositing are up-to-date

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 471623003: WebLocalFrameImpl::printPage needs to ensure layout, style, and compositing are up-to-date (Closed)

Created:
6 years, 4 months ago by abarth-chromium

Modified:
6 years, 4 months ago

Reviewers:
adamk

CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

WebLocalFrameImpl::printPage needs to ensure layout, style, and compositing are up-to-date Previously, we could try to paint without having our painting state up-to-date. The codepath for printing multiple pages updatesLayoutAndStyleForPainting. This CL makes the code path for printing single pages do the same. R=adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180200

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -24 lines)			Patch
M	Source/core/frame/FrameView.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/RenderLayer.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/web/WebLocalFrameImpl.cpp	View	4 chunks	+31 lines, -21 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/471623003/1

6 years, 4 months ago (2014-08-13 18:22:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 180200

Expand Messages | Collapse Messages