Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1185)

Unified Diff: gin/shell/gin_shell_unittest.cc

Issue 471623002: Verify that gin_shell and hello_world.js exist. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/shell/gin_shell_unittest.cc
diff --git a/gin/shell/gin_shell_unittest.cc b/gin/shell/gin_shell_unittest.cc
index 0df979de71b6d5ef7286d94809b0d41a7e777c56..52d599354fcc0bfd2acf0d02f853db3eeaa7a0f4 100644
--- a/gin/shell/gin_shell_unittest.cc
+++ b/gin/shell/gin_shell_unittest.cc
@@ -3,7 +3,7 @@
// found in the LICENSE file.
#include "base/command_line.h"
-#include "base/files/file_path.h"
+#include "base/file_util.h"
#include "base/path_service.h"
#include "base/process/launch.h"
#include "base/strings/string_util.h"
@@ -25,8 +25,13 @@ base::FilePath HelloWorldPath() {
}
TEST(GinShellTest, HelloWorld) {
- CommandLine cmd(GinShellPath());
- cmd.AppendArgPath(HelloWorldPath());
+ base::FilePath ginShellPath(GinShellPath());
abarth-chromium 2014/08/13 18:00:16 gin_shell_path?
hansmuller 2014/08/13 19:22:14 Yes, sorry about that. I've been writing a lot of
+ base::FilePath helloWorldPath(HelloWorldPath());
+ ASSERT_TRUE(base::PathExists(ginShellPath));
+ ASSERT_TRUE(base::PathExists(helloWorldPath));
+
+ CommandLine cmd(ginShellPath);
+ cmd.AppendArgPath(helloWorldPath);
std::string output;
ASSERT_TRUE(base::GetAppOutput(cmd, &output));
base::TrimWhitespaceASCII(output, base::TRIM_ALL, &output);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698