net/quic/quic_sent_packet_manager.cc - Issue 471613002: Change how QUIC negotiates pacing from congestion feedback to QUIC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_sent_packet_manager.cc

Issue 471613002: Change how QUIC negotiates pacing from congestion feedback to QUIC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Add_max_bandwidth_max_bandwidth_timestamp_73055131

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_sent_packet_manager.cc

diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc

index ce6af66e0cd7c91467c661bc062b6f4f3362fde9..292afa635fcb63ac6e2427004fab08d0d0c4f991 100644

--- a/net/quic/quic_sent_packet_manager.cc

+++ b/net/quic/quic_sent_packet_manager.cc

@@ -113,9 +113,8 @@ void QuicSentPacketManager::SetFromConfig(const QuicConfig& config) {

send_algorithm_.reset(

SendAlgorithmInterface::Create(clock_, &rtt_stats_, kReno, stats_));

}

- if (config.congestion_feedback() == kPACE ||

- (config.HasReceivedConnectionOptions() &&

- ContainsQuicTag(config.ReceivedConnectionOptions(), kPACE))) {

+ if (config.HasReceivedConnectionOptions() &&

+ ContainsQuicTag(config.ReceivedConnectionOptions(), kPACE)) {

MaybeEnablePacing();

}

// TODO(ianswett): Remove the "HasReceivedLossDetection" branch once

« net/quic/quic_connection.cc ('K') | « net/quic/quic_crypto_client_stream_test.cc ('k') | net/quic/quic_stream_factory.h » ('j') | no next file with comments »