net/http/http_network_session.cc - Issue 471613002: Change how QUIC negotiates pacing from congestion feedback to QUIC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_session.cc

Issue 471613002: Change how QUIC negotiates pacing from congestion feedback to QUIC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Add_max_bandwidth_max_bandwidth_timestamp_73055131

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_network_session.cc

diff --git a/net/http/http_network_session.cc b/net/http/http_network_session.cc

index b48d660dc74ebea664cb50a794d397ad4e5cbfd1..cebbb1d4b7c0dda72efc3dd71043d7647da9b4bd 100644

--- a/net/http/http_network_session.cc

+++ b/net/http/http_network_session.cc

@@ -20,6 +20,7 @@

#include "net/quic/crypto/quic_random.h"

#include "net/quic/quic_clock.h"

#include "net/quic/quic_crypto_client_stream_factory.h"

+#include "net/quic/quic_protocol.h"

#include "net/quic/quic_stream_factory.h"

#include "net/socket/client_socket_factory.h"

#include "net/socket/client_socket_pool_manager_impl.h"

@@ -87,7 +88,6 @@ HttpNetworkSession::Params::Params()

enable_websocket_over_spdy(false),

enable_quic(false),

enable_quic_port_selection(true),

- enable_quic_pacing(false),

enable_quic_time_based_loss_detection(false),

quic_clock(NULL),

quic_random(NULL),

@@ -129,7 +129,6 @@ HttpNetworkSession::HttpNetworkSession(const Params& params)

params.quic_user_agent_id,

params.quic_supported_versions,

params.enable_quic_port_selection,

- params.enable_quic_pacing,

params.enable_quic_time_based_loss_detection,

params.quic_connection_options),

spdy_session_pool_(params.host_resolver,

@@ -252,7 +251,7 @@ base::Value* HttpNetworkSession::QuicInfoToValue() const {

dict->SetBoolean("enable_quic_port_selection",

params_.enable_quic_port_selection);

dict->SetBoolean("enable_quic_pacing",

- params_.enable_quic_pacing);

+ ContainsQuicTag(params_.quic_connection_options, kPACE));

Ryan Hamilton 2014/08/13 16:33:40 Consider removing "enable_quic_pacing" and replaci

ramant (doing other things) 2014/08/14 02:45:48 Fixed it in CL: https://chromiumcodereview.appspot

dict->SetBoolean("enable_quic_time_based_loss_detection",

params_.enable_quic_time_based_loss_detection);

dict->SetString("origin_to_force_quic_on",

« no previous file with comments | « net/http/http_network_session.h ('k') | net/quic/crypto/crypto_protocol.h » ('j') | net/quic/quic_connection.cc » ('J')