gpu: support immutable texture on Linux Mesa driver and GLES3.

gpu: support immutable texture on Linux Mesa driver and GLES3.

Mesa GL driver supports GL_ARB_texture_storage extensions, not
GL_EXT_texture_storage. GLES3 supports glTexStroage2D by default.
This CL makes Intel Chromebook and Linux take advantage of
immutable texture.

BUG=106142
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290676

[dshwang, 2014-08-19 09:19:52]

Could you review?
It makes Linux Intel GPU take advantage of immutable texture.

[dshwang, 2014-08-19 09:34:01]

For example, Acer C720, i.e. peppy, needs this CL.

[bsalomon, 2014-08-19 13:28:44]

https://codereview.chromium.org/471603003/diff/1/gpu/command_buffer/service/f...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/471603003/diff/1/gpu/command_buffer/service/f...
gpu/command_buffer/service/feature_info.cc:694: if
(extensions.Contains("GL_EXT_texture_storage") ||
Shouldn't there also be an is_es3 check here?

[dshwang, 2014-08-19 18:02:53]

On 2014/08/19 13:28:44, bsalomon wrote:
>
https://codereview.chromium.org/471603003/diff/1/gpu/command_buffer/service/f...
> File gpu/command_buffer/service/feature_info.cc (right):
> 
>
https://codereview.chromium.org/471603003/diff/1/gpu/command_buffer/service/f...
> gpu/command_buffer/service/feature_info.cc:694: if
> (extensions.Contains("GL_EXT_texture_storage") ||
> Shouldn't there also be an is_es3 check here?

Yes, we need to support it on es3 also. I updated it.

[bsalomon, 2014-08-19 19:14:03]

lgtm, but I'm not a valid reviewer :(

[piman, 2014-08-19 20:20:39]

lgtm

[dshwang, 2014-08-19 20:37:50]

Thank you for review!

[dshwang, 2014-08-19 20:37:53]

The CQ bit was checked by dongseong.hwang@intel.com

[commit-bot: I haz the power, 2014-08-19 20:38:50]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/471603003/20001

[commit-bot: I haz the power, 2014-08-19 22:10:57]

Committed patchset #2 (20001) as 290676

[spang, 2014-08-20 20:46:14]

A revert of this CL (patchset #2) has been created in
https://codereview.chromium.org/494843002/ by spang@chromium.org.

The reason for reverting is: causes black rectangles on chromeos link_freon.

[piman, 2014-08-21 00:16:34]

On Wed, Aug 20, 2014 at 1:46 PM, <spang@chromium.org> wrote:

> A revert of this CL (patchset #2) has been created in
> https://codereview.chromium.org/494843002/ by spang@chromium.org.
>
> The reason for reverting is: causes black rectangles on chromeos
> link_freon.
>

Any details of the failure? Are there any GL errors?
It's not clear to me why this would pass on the GL driver but fail on freon
(GLES3). The entrypoint should be the same.


>
> https://codereview.chromium.org/471603003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dshwang, 2014-08-21 08:50:05]

On 2014/08/21 00:16:34, piman (OOO) wrote:
> On Wed, Aug 20, 2014 at 1:46 PM, <mailto:spang@chromium.org> wrote:
> 
> > A revert of this CL (patchset #2) has been created in
> > https://codereview.chromium.org/494843002/ by mailto:spang@chromium.org.
> >
> > The reason for reverting is: causes black rectangles on chromeos
> > link_freon.
> >
> 
> Any details of the failure? Are there any GL errors?
> It's not clear to me why this would pass on the GL driver but fail on freon
> (GLES3). The entrypoint should be the same.
> 
> 
> >
> > https://codereview.chromium.org/471603003/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Hi, thank you for reporting. glTexStorage2D on gl_renderer can cause the black
rect bug.

device wiki doesn't have freon;
http://www.chromium.org/chromium-os/developer-information-for-chrome-os-devices
Could you tell me what's freon spec? especially gpu. If you copy&paste
chrome://gpu, I'll very appreciate it.
I'll investigate it using peppy because I guess peppy has similar spec to freon.