Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 471543002: Add more detailed UMA reporting on enrollment errors. (Closed)

Created:
6 years, 4 months ago by Thiemo Nagel
Modified:
6 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add more detailed UMA reporting on enrollment errors. BUG=305457 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289317

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M chrome/browser/chromeos/login/enrollment/enrollment_screen.cc View 1 chunk +7 lines, -1 line 0 comments Download
M components/policy/core/common/cloud/enterprise_metrics.h View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Thiemo Nagel
Hi Joao, I'm extending the EnterpriseEnrollmentType UMA to distinguish between four more error cases. Could ...
6 years, 4 months ago (2014-08-13 13:04:24 UTC) #1
Thiemo Nagel
Hi Alexei, I'm extending the EnterpriseEnrollmentType UMA to distinguish between four more error cases. Could ...
6 years, 4 months ago (2014-08-13 13:05:31 UTC) #2
Joao da Silva
lgtm
6 years, 4 months ago (2014-08-13 13:43:21 UTC) #3
Thiemo Nagel
Thank you!
6 years, 4 months ago (2014-08-13 14:02:15 UTC) #4
Alexei Svitkine (slow)
lgtm
6 years, 4 months ago (2014-08-13 14:29:38 UTC) #5
Thiemo Nagel
Thank you!
6 years, 4 months ago (2014-08-13 14:31:01 UTC) #6
Thiemo Nagel
The CQ bit was checked by tnagel@chromium.org
6 years, 4 months ago (2014-08-13 14:31:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/471543002/1
6 years, 4 months ago (2014-08-13 14:32:09 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 16:32:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (1) as 289317

Powered by Google App Engine
This is Rietveld 408576698