rename TestMojoServiceManager to TestMojoApplicationManager in chrome_tests.py

rename TestMojoServiceManager to TestMojoApplicationManager in chrome_tests.py

R=aa@chromium.org, oshima@chromium.org
BUG=403177
NOTRY=TRUE

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289322

[Aaron Boodman, 2014-08-13 15:17:18]

Lgtm

-a (phone)
On Aug 13, 2014 8:10 AM, <zhaoqin@google.com> wrote:

> Reviewers: Aaron Boodman, oshima,
>
> Description:
> rename TestMojoServiceManager to TestMojoApplicationManager in
> chrome_tests.py
>
> R=aa@chromium.org, oshima@chromium.org
> BUG=403177
> NOTRY=TRUE
>
> Please review this at https://codereview.chromium.org/471533003/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+2, -2 lines):
>   M tools/valgrind/chrome_tests.py
>
>
> Index: tools/valgrind/chrome_tests.py
> diff --git a/tools/valgrind/chrome_tests.py b/tools/valgrind/chrome_tests.
> py
> index 5c0e896bb404ec7987ebe6cee464b173547bda02..
> 89b9671cb9e73480e56f9a637e087ee3ccd12fd0 100755
> --- a/tools/valgrind/chrome_tests.py
> +++ b/tools/valgrind/chrome_tests.py
> @@ -404,7 +404,7 @@ class ChromeTests:
>      return self.SimpleTest("mojo_public_utility",
>                             "mojo_public_utility_unittests")
>
> -  def TestMojoServiceManager(self):
> +  def TestMojoApplicationManager(self):
>      return self.SimpleTest("mojo_application_manager",
>                             "mojo_application_manager_unittests")
>
> @@ -690,7 +690,7 @@ class ChromeTests:
>      "mojo_public_bindings": TestMojoPublicBindings,
>      "mojo_public_env": TestMojoPublicEnv,
>      "mojo_public_sysperf": TestMojoPublicSysPerf,
> -    "mojo_application_manager": TestMojoServiceManager,
> +    "mojo_application_manager": TestMojoApplicationManager,
>      "mojo_view_manager": TestMojoViewManager,
>      "mojo_view_manager_lib": TestMojoViewManagerLib,
>      "net": TestNet,              "net_unittests": TestNet,
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[zhaoqin, 2014-08-13 15:31:32]

The CQ bit was checked by zhaoqin@google.com

[commit-bot: I haz the power, 2014-08-13 15:32:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zhaoqin@google.com/471533003/1

[commit-bot: I haz the power, 2014-08-13 15:32:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-13 15:32:06]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[oshima, 2014-08-13 16:54:25]

lgtm

[oshima, 2014-08-13 16:54:45]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-08-13 16:55:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/zhaoqin@google.com/471533003/1

[oshima, 2014-08-13 16:55:21]

https://codereview.chromium.org/471533003/diff/1/tools/valgrind/chrome_tests.py
File tools/valgrind/chrome_tests.py (right):

https://codereview.chromium.org/471533003/diff/1/tools/valgrind/chrome_tests....
tools/valgrind/chrome_tests.py:695: "mojo_view_manager_lib":
TestMojoViewManagerLib,
are you going to remove this in separate CL?

[commit-bot: I haz the power, 2014-08-13 16:57:01]

Committed patchset #1 (1) as 289322

[zhaoqin, 2014-08-13 18:07:05]

On 2014/08/13 16:55:21, oshima wrote:
>
https://codereview.chromium.org/471533003/diff/1/tools/valgrind/chrome_tests.py
> File tools/valgrind/chrome_tests.py (right):
> 
>
https://codereview.chromium.org/471533003/diff/1/tools/valgrind/chrome_tests....
> tools/valgrind/chrome_tests.py:695: "mojo_view_manager_lib":
> TestMojoViewManagerLib,
> are you going to remove this in separate CL?

hmm, forget to remove that, will have a separate CL for it.