Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Side by Side Diff: src/compiler/ia32/code-generator-ia32.cc

Issue 471523002: Remove a brittle assertion from Turbofan lazy deoptimization handling. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Remove redundant method Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/compiler/code-generator.cc ('k') | src/compiler/x64/code-generator-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/compiler/code-generator-impl.h" 7 #include "src/compiler/code-generator-impl.h"
8 #include "src/compiler/gap-resolver.h" 8 #include "src/compiler/gap-resolver.h"
9 #include "src/compiler/node-matchers.h" 9 #include "src/compiler/node-matchers.h"
10 #include "src/compiler/node-properties-inl.h" 10 #include "src/compiler/node-properties-inl.h"
(...skipping 920 matching lines...) Expand 10 before | Expand all | Expand 10 after
931 // No other combinations are possible. 931 // No other combinations are possible.
932 UNREACHABLE(); 932 UNREACHABLE();
933 } 933 }
934 } 934 }
935 935
936 936
937 void CodeGenerator::AddNopForSmiCodeInlining() { __ nop(); } 937 void CodeGenerator::AddNopForSmiCodeInlining() { __ nop(); }
938 938
939 #undef __ 939 #undef __
940 940
941 #ifdef DEBUG
942
943 // Checks whether the code between start_pc and end_pc is a no-op.
944 bool CodeGenerator::IsNopForSmiCodeInlining(Handle<Code> code, int start_pc,
945 int end_pc) {
946 if (start_pc + 1 != end_pc) {
947 return false;
948 }
949 return *(code->instruction_start() + start_pc) ==
950 v8::internal::Assembler::kNopByte;
951 }
952
953 #endif // DEBUG
954 } 941 }
955 } 942 }
956 } // namespace v8::internal::compiler 943 } // namespace v8::internal::compiler
OLDNEW
« no previous file with comments | « src/compiler/code-generator.cc ('k') | src/compiler/x64/code-generator-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698