Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 471523002: Remove a brittle assertion from Turbofan lazy deoptimization handling. (Closed)

Created:
6 years, 4 months ago by Jarin
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove a brittle assertion from Turbofan lazy deoptimization handling. As discussed in person with Benedikt, it is better to remove the assertion because it is too brittle. The assertion says that the continuation block should immediately follow the call. However, there are exceptions - such as nop or constant pool in-between being fine - that make the assertion brittle. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23102

Patch Set 1 #

Patch Set 2 : Remove redundant method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -75 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 1 chunk +0 lines, -17 lines 0 comments Download
M src/compiler/code-generator.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/code-generator.cc View 1 2 chunks +0 lines, -12 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 1 chunk +0 lines, -13 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 1 chunk +0 lines, -14 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jarin
Could you take a look, please?
6 years, 4 months ago (2014-08-13 11:35:06 UTC) #1
Michael Starzinger
LGTM.
6 years, 4 months ago (2014-08-13 11:45:44 UTC) #2
Jarin
6 years, 4 months ago (2014-08-13 11:46:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 23102 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698