Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 471493003: Revert of Update V8 to version 3.28.71 (based on bleeding_edge revision r23062). (Closed)

Created:
6 years, 4 months ago by lushnikov
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Revert of Update V8 to version 3.28.71 (based on bleeding_edge revision r23062). (patchset #1 of https://codereview.chromium.org/459373002/) Reason for revert: This broke developer tools editor. Please see https://code.google.com/p/chromium/issues/detail?id=403521 Original issue's description: > Update V8 to version 3.28.71 (based on bleeding_edge revision r23062). > > TBR=jochen@chromium.org > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288989 TBR=jochen@chromium.org,machenbach@chromium.org NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
lushnikov
Created Revert of Update V8 to version 3.28.71 (based on bleeding_edge revision r23062).
6 years, 4 months ago (2014-08-13 21:06:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/471493003/1
6 years, 4 months ago (2014-08-13 21:08:23 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 21:10:55 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 21:10:56 UTC) #4
Failed to apply patch for DEPS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file DEPS
  Hunk #1 FAILED at 51.
  1 out of 1 hunk FAILED -- saving rejects to file DEPS.rej

Patch:       DEPS
Index: DEPS
diff --git a/DEPS b/DEPS
index
0c52baa4e56a2165f825a9eb8870befb5cdf083b..61fab28fcd7ceb51134e40e87ebffc0ad16cbcce
100644
--- a/DEPS
+++ b/DEPS
@@ -51,7 +51,7 @@
   # the commit queue can handle CLs rolling Skia
   # and V8 without interference from each other.
   "v8_branch": "trunk",
-  "v8_revision": "23064",
+  "v8_revision": "23036",
   # Three lines of non-changing comments so that
   # the commit queue can handle CLs rolling WebRTC
   # and V8 without interference from each other.

Powered by Google App Engine
This is Rietveld 408576698