src/core/SkDraw.cpp - Issue 471473002: Optimize CSS box-shadow performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkDraw.cpp

Issue 471473002: Optimize CSS box-shadow performance (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: store SkMask and SkCachedData in cache Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkDraw.cpp

diff --git a/src/core/SkDraw.cpp b/src/core/SkDraw.cpp

index 929088df17d25f206cab35fbc7b5ac240fba7411..c194b31b10d61fbfc722ec48f161977c4eafafda 100644

--- a/src/core/SkDraw.cpp

+++ b/src/core/SkDraw.cpp

@@ -880,7 +880,7 @@ void SkDraw::drawDevMask(const SkMask& srcM, const SkPaint& paint) const {

SkMask dstM;

if (paint.getMaskFilter() &&

- paint.getMaskFilter()->filterMask(&dstM, srcM, *fMatrix, NULL)) {

+ paint.getMaskFilter()->filterMask(&dstM, srcM, *fMatrix, NULL, NULL)) {

mask = &dstM;

} else {

dstM.fImage = NULL;

@@ -2306,7 +2306,7 @@ static bool compute_bounds(const SkPath& devPath, const SkIRect* clipBounds,

srcM.fBounds = *bounds;

srcM.fFormat = SkMask::kA8_Format;

srcM.fImage = NULL;

- if (!filter->filterMask(&dstM, srcM, *filterMatrix, &margin)) {

+ if (!filter->filterMask(&dstM, srcM, *filterMatrix, &margin, NULL)) {

return false;

}