bench/BlurRectBench.cpp - Issue 471473002: Optimize CSS box-shadow performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: bench/BlurRectBench.cpp

Issue 471473002: Optimize CSS box-shadow performance (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: backed blur mask with a bitmap Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: bench/BlurRectBench.cpp

diff --git a/bench/BlurRectBench.cpp b/bench/BlurRectBench.cpp

index cdcdfe57f3442d0f6abab449e008e8a2e808c9ce..b75e8c74d3d192fbf026e3399b934ca7be83b18d 100644

--- a/bench/BlurRectBench.cpp

+++ b/bench/BlurRectBench.cpp

@@ -92,7 +92,6 @@ protected:

SkMask mask;

SkBlurMask::BlurRect(SkBlurMask::ConvertRadiusToSigma(this->radius()),

&mask, r, kNormal_SkBlurStyle);

- SkMask::FreeImage(mask.fImage);

}

private:

typedef BlurRectBench INHERITED;

@@ -147,7 +146,6 @@ protected:

mask.fImage = NULL;

SkBlurMask::BoxBlur(&mask, fSrcMask, SkBlurMask::ConvertRadiusToSigma(this->radius()),

kNormal_SkBlurStyle, kHigh_SkBlurQuality);

- SkMask::FreeImage(mask.fImage);

}

private:

typedef BlurRectSeparableBench INHERITED;

« no previous file with comments | « no previous file | gm/blurrect.cpp » ('j') | src/core/SkBitmapCache.cpp » ('J')