Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 471443002: [Telemetry] Remove some dead code. (Closed)

Created:
6 years, 4 months ago by tonyg
Modified:
6 years, 4 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Remove some dead code. The LocalServerController closes the LocalServer now. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289258

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M tools/telemetry/telemetry/core/browser.py View 3 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tonyg
6 years, 4 months ago (2014-08-13 05:57:22 UTC) #1
dtu
lgtm
6 years, 4 months ago (2014-08-13 06:08:15 UTC) #2
dtu
The CQ bit was checked by dtu@chromium.org
6 years, 4 months ago (2014-08-13 06:08:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/471443002/20001
6 years, 4 months ago (2014-08-13 06:10:44 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 10:25:54 UTC) #5
Message was sent while issue was closed.
Change committed as 289258

Powered by Google App Engine
This is Rietveld 408576698