Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 471433007: [Ozone-Dri] Adding initial content protection support (Closed)

Created:
6 years, 4 months ago by dnicoara
Modified:
6 years, 3 months ago
CC:
chromium-reviews, rjkroege, kalyank, stevenjb+watch_chromium.org, oshima+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Ozone-Dri] Adding initial content protection support BUG=403322 NOTRY=true Committed: https://crrev.com/a385d68db77f7fd5c4059cc5d9bc12027a911aea Cr-Commit-Position: refs/heads/master@{#291923}

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Patch Set 3 : Move DCHECK #

Patch Set 4 : cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -3 lines) Patch
M ui/ozone/platform/dri/chromeos/native_display_delegate_dri.cc View 1 2 3 2 chunks +82 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/dri_wrapper.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/dri_wrapper.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/test/mock_dri_wrapper.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/dri/test/mock_dri_wrapper.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dnicoara
dnicoara@chromium.org changed reviewers: + alexst@chromium.org
6 years, 4 months ago (2014-08-25 23:56:13 UTC) #1
dnicoara
PTAL
6 years, 4 months ago (2014-08-25 23:56:13 UTC) #2
alexst (slow to review)
lgtm https://codereview.chromium.org/471433007/diff/1/ui/ozone/platform/dri/chromeos/native_display_delegate_dri.cc File ui/ozone/platform/dri/chromeos/native_display_delegate_dri.cc (right): https://codereview.chromium.org/471433007/diff/1/ui/ozone/platform/dri/chromeos/native_display_delegate_dri.cc#newcode42 ui/ozone/platform/dri/chromeos/native_display_delegate_dri.cc:42: name = kContentProtectionStates[i].name; Once you found a name, ...
6 years, 4 months ago (2014-08-26 00:32:04 UTC) #3
dnicoara
https://codereview.chromium.org/471433007/diff/1/ui/ozone/platform/dri/chromeos/native_display_delegate_dri.cc File ui/ozone/platform/dri/chromeos/native_display_delegate_dri.cc (right): https://codereview.chromium.org/471433007/diff/1/ui/ozone/platform/dri/chromeos/native_display_delegate_dri.cc#newcode42 ui/ozone/platform/dri/chromeos/native_display_delegate_dri.cc:42: name = kContentProtectionStates[i].name; On 2014/08/26 00:32:04, alexst wrote: > ...
6 years, 4 months ago (2014-08-26 00:43:51 UTC) #4
dnicoara
The CQ bit was checked by dnicoara@chromium.org
6 years, 3 months ago (2014-08-26 17:16:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/471433007/50001
6 years, 3 months ago (2014-08-26 17:17:48 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (50001) as daab23ddeae606d07304f1ddfa5e27506e93e5cd
6 years, 3 months ago (2014-08-26 17:19:09 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:43:29 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/a385d68db77f7fd5c4059cc5d9bc12027a911aea
Cr-Commit-Position: refs/heads/master@{#291923}

Powered by Google App Engine
This is Rietveld 408576698