Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 471423002: remove DocumentParser::startParsing() (Closed)

Created:
6 years, 4 months ago by kouhei (in TOK)
Modified:
6 years, 4 months ago
Reviewers:
haraken, eseidel
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Project:
blink
Visibility:
Public.

Description

remove DocumentParser::startParsing() This CL removes |DocumentParser::startParsing()|. This was only used from XMLDocumentParser, but it was a no-op. The method initializes |m_state| to |ParsingState|, however the state should already be in |ParsingState| from c-tor initializer. BUG=404107 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180425

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M Source/core/dom/DocumentParser.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/DocumentParser.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kouhei (in TOK)
Would you take a look?
6 years, 4 months ago (2014-08-15 12:26:37 UTC) #1
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 4 months ago (2014-08-18 05:53:36 UTC) #2
eseidel
lgtm
6 years, 4 months ago (2014-08-18 05:53:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/471423002/1
6 years, 4 months ago (2014-08-18 05:54:12 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 05:57:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 180425

Powered by Google App Engine
This is Rietveld 408576698