Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 471413003: Discover git.bat even if git_cl.py is executed using relative path (Closed)

Created:
6 years, 4 months ago by anatoly techtonik
Modified:
6 years, 4 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Discover git.bat even if git_cl.py is executed using relative path This allows git_cl.py to be used without adding depot_tools to PATH BUG= R=iannucci@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=289992

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M git_common.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
anatoly techtonik
6 years, 4 months ago (2014-08-15 19:49:00 UTC) #1
iannucci
lgtm, please CQ :)
6 years, 4 months ago (2014-08-15 19:52:28 UTC) #2
anatoly techtonik
The CQ bit was checked by techtonik@gmail.com
6 years, 4 months ago (2014-08-15 19:59:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/techtonik@gmail.com/471413003/1
6 years, 4 months ago (2014-08-15 19:59:45 UTC) #4
anatoly techtonik
I can commit with a single checkbox?! Damn, that's a good automation. =)
6 years, 4 months ago (2014-08-15 20:01:37 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 20:01:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 289992

Powered by Google App Engine
This is Rietveld 408576698