DevTools: Avoid exception when inspecting blob-based workers

DevTools: Avoid exception when inspecting blob-based workers

The blob: scheme is not handled by ParsedURL, so it is
impossible to compute the human-readable worker name
for them using the common scheme.

R=pfeldman, vsevik
BUG=404098
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180356

[vsevik, 2014-08-15 11:53:02]

The CQ bit was checked by vsevik@chromium.org

[vsevik, 2014-08-15 11:53:03]

lgtm

[commit-bot: I haz the power, 2014-08-15 11:54:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/apavlov@chromium.org/471413002/1

[commit-bot: I haz the power, 2014-08-15 11:54:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-15 11:54:16]

Failed to apply patch for Source/devtools/front_end/sdk/WorkerTargetManager.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/devtools/front_end/sdk/WorkerTargetManager.js
  Hunk #1 FAILED at 13.
  1 out of 3 hunks FAILED -- saving rejects to file
Source/devtools/front_end/sdk/WorkerTargetManager.js.rej

Patch:       Source/devtools/front_end/sdk/WorkerTargetManager.js
Index: Source/devtools/front_end/sdk/WorkerTargetManager.js
diff --git a/Source/devtools/front_end/sdk/WorkerTargetManager.js
b/Source/devtools/front_end/sdk/WorkerTargetManager.js
index
8bd0622bf868bae23aeffbdf1302d2eb7e65dc44..e688e806972e07c5d59c1044728cc2ea824dd520
100644
--- a/Source/devtools/front_end/sdk/WorkerTargetManager.js
+++ b/Source/devtools/front_end/sdk/WorkerTargetManager.js
@@ -13,8 +13,10 @@ WebInspector.WorkerTargetManager = function(mainTarget,
targetManager)
     this._mainTarget = mainTarget;
     this._targetManager = targetManager;
    
mainTarget.workerManager.addEventListener(WebInspector.WorkerManager.Events.WorkerAdded,
this._onWorkerAdded, this);
+   
mainTarget.workerManager.addEventListener(WebInspector.WorkerManager.Events.WorkersCleared,
this._onWorkersCleared, this);
    
WebInspector.profilingLock.addEventListener(WebInspector.Lock.Events.StateChanged,
this._onProfilingStateChanged, this);
     this._onProfilingStateChanged();
+    this._lastAnonymousTargetId = 0;
 }
 
 WebInspector.WorkerTargetManager.prototype = {
@@ -38,7 +40,9 @@ WebInspector.WorkerTargetManager.prototype = {
          */
         function onConnectionReady(connection)
         {
-            this._targetManager.createTarget(WebInspector.UIString("Worker %s",
data.url.asParsedURL().lastPathComponent), connection, targetCreated)
+            var parsedURL = data.url.asParsedURL();
+            var workerId = parsedURL ? parsedURL.lastPathComponent : "#" +
(++this._lastAnonymousTargetId);
+            this._targetManager.createTarget(WebInspector.UIString("Worker %s",
workerId), connection, targetCreated);
         }
 
         /**
@@ -49,6 +53,11 @@ WebInspector.WorkerTargetManager.prototype = {
             if (data.inspectorConnected)
                 target.runtimeAgent().run();
         }
+    },
+
+    _onWorkersCleared: function()
+    {
+        this._lastAnonymousTargetId = 0;
     }
 }

[apavlov, 2014-08-15 12:03:36]

The CQ bit was checked by apavlov@chromium.org

[commit-bot: I haz the power, 2014-08-15 12:04:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/apavlov@chromium.org/471413002/20001

[commit-bot: I haz the power, 2014-08-15 12:04:39]

Committed patchset #2 (20001) as 180356