Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 471403005: Revert of ChromeOS: should not show "Language changed" notification for certain languages. (Closed)

Created:
6 years, 4 months ago by miu
Modified:
6 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, jshin+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of ChromeOS: should not show "Language changed" notification for certain languages. (patchset #6 of https://codereview.chromium.org/382973002/) Reason for revert: Link failure of browser_tests on ChromiumOS build bot: http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Builder%20%28dbg%29&number=50192 Original issue's description: > ChromeOS: should not show "Language changed" notification for certain languages. > > BUG=317718 > TEST=manually tested > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289985 NOTREECHECKS=true NOTRY=true TBR=alemate@chromium.org, nkostylev@chromium.org, jshin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290017

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -308 lines) Patch
M chrome/browser/chromeos/locale_change_guard.h View 3 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/locale_change_guard.cc View 4 chunks +1 line, -49 lines 0 comments Download
D chrome/browser/chromeos/locale_change_guard_unittest.cc View 1 chunk +0 lines, -220 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/l10n_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/l10n/l10n_util.h View 2 chunks +0 lines, -7 lines 0 comments Download
M ui/base/l10n/l10n_util.cc View 3 chunks +4 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
miu
Created Revert of ChromeOS: should not show "Language changed" notification for certain languages.
6 years, 4 months ago (2014-08-15 21:02:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/471403005/1
6 years, 4 months ago (2014-08-15 21:04:25 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 21:04:26 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-15 21:04:27 UTC) #4
miu
The CQ bit was checked by miu@chromium.org
6 years, 4 months ago (2014-08-15 21:09:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/471403005/1
6 years, 4 months ago (2014-08-15 21:12:51 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-15 21:12:52 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 4 months ago (2014-08-15 21:12:54 UTC) #8
miu
The CQ bit was checked by miu@chromium.org
6 years, 4 months ago (2014-08-15 21:21:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/471403005/1
6 years, 4 months ago (2014-08-15 21:22:34 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 21:31:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (1) as 290017

Powered by Google App Engine
This is Rietveld 408576698