Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 471393002: Revert of Make profiling lock global rather than per Target (Closed)

Created:
6 years, 4 months ago by pfeldman
Modified:
6 years, 4 months ago
Reviewers:
apavlov, sergeyv, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Revert of Make profiling lock global rather than per Target (patchset #2 of https://codereview.chromium.org/475803002/) Reason for revert: 'common' should not be aware of profiler. Original issue's description: > Make profiling lock global rather than per Target > > We should pause any actions that could affect performance if any of the targets is being profiled, not only current target. > > BUG=403684 > R=sergeyv@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180336 TBR=sergeyv@chromium.org,apavlov@chromium.org,yurys@chromium.org NOTREECHECKS=true NOTRY=true BUG=403684 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -83 lines) Patch
M Source/devtools/devtools.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/audits/AuditLauncherView.js View 3 chunks +4 lines, -4 lines 0 comments Download
D Source/devtools/front_end/common/Lock.js View 1 chunk +0 lines, -51 lines 0 comments Download
M Source/devtools/front_end/common/Object.js View 1 chunk +45 lines, -0 lines 0 comments Download
M Source/devtools/front_end/inspector.html View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/profiler/CanvasProfileView.js View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/profiler/ProfilesPanel.js View 4 chunks +21 lines, -4 lines 0 comments Download
M Source/devtools/front_end/sdk/CSSStyleModel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/DOMModel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/DebuggerModel.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/Target.js View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sdk/TimelineManager.js View 3 chunks +6 lines, -3 lines 0 comments Download
M Source/devtools/front_end/sdk/TracingModel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/WorkerTargetManager.js View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 4 chunks +18 lines, -2 lines 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
pfeldman
Created Revert of Make profiling lock global rather than per Target
6 years, 4 months ago (2014-08-15 09:14:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/471393002/1
6 years, 4 months ago (2014-08-15 09:14:56 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 09:15:26 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (1) as 180342

Powered by Google App Engine
This is Rietveld 408576698