Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 471363003: overrideMimeType should be called after open to be spec compliant (Closed)

Created:
6 years, 4 months ago by kouhei (in TOK)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

overrideMimeType should be called after open to be spec compliant Before this CL, RSS tests invoked XMLHttpRequest.overrideMimeType on DONE state. This relies on a spec inconsistent behavior of current Blink. http://www.w3.org/TR/XMLHttpRequest2/#the-overridemimetype-method This change moves the call after open, so that |overrideMimeType| is called at OPENED state, which is safe. BUG=402375 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290485

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/data/extensions/subscribe_page_action/subscribe.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kouhei (in TOK)
Would you take a look? This needs to land before https://codereview.chromium.org/478223002/
6 years, 4 months ago (2014-08-19 00:31:26 UTC) #1
tyoshino (SeeGerritForStatus)
lgtm
6 years, 4 months ago (2014-08-19 03:03:56 UTC) #2
kouhei (in TOK)
The CQ bit was checked by kouhei@chromium.org
6 years, 4 months ago (2014-08-19 03:25:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/471363003/1
6 years, 4 months ago (2014-08-19 03:26:17 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 04:10:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 290485

Powered by Google App Engine
This is Rietveld 408576698