Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 471243002: Enable start_host compilation on Windows. (Closed)

Created:
6 years, 4 months ago by Sergey Ulanov
Modified:
6 years, 3 months ago
Reviewers:
dcaiafa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable start_host compilation on Windows and Mac. BUG=386441 Committed: https://crrev.com/67945b28c51b5d550ad7ea87a798a409b373346b Cr-Commit-Position: refs/heads/master@{#294214}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -22 lines) Patch
M remoting/host/setup/start_host.cc View 4 chunks +16 lines, -2 lines 0 comments Download
M remoting/remoting_host.gypi View 1 1 chunk +19 lines, -1 line 0 comments Download
M remoting/remoting_host_linux.gypi View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 41 (6 generated)
Sergey Ulanov
6 years, 4 months ago (2014-08-14 21:59:38 UTC) #1
Sergey Ulanov
+dcaiafa -rmsousa Dan, PTAL
6 years, 4 months ago (2014-08-20 00:41:12 UTC) #2
dcaiafa
lgtm
6 years, 4 months ago (2014-08-20 15:53:00 UTC) #3
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 4 months ago (2014-08-20 17:19:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/471243002/1
6 years, 4 months ago (2014-08-20 17:21:01 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-20 21:12:20 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 21:16:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg/builds/7903) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/7863) mac_chromium_rel_swarming ...
6 years, 4 months ago (2014-08-20 21:16:20 UTC) #8
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 4 months ago (2014-08-20 23:59:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/471243002/1
6 years, 4 months ago (2014-08-21 00:00:19 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-21 00:57:18 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 01:00:22 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg/builds/8116) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/7971) mac_chromium_rel_swarming ...
6 years, 4 months ago (2014-08-21 01:00:23 UTC) #13
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 4 months ago (2014-08-21 17:40:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/471243002/1
6 years, 4 months ago (2014-08-21 17:43:29 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-21 17:55:49 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 17:58:46 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/8211) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/5654)
6 years, 4 months ago (2014-08-21 17:58:47 UTC) #18
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 4 months ago (2014-08-21 18:02:33 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/471243002/1
6 years, 4 months ago (2014-08-21 18:04:27 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-21 18:13:06 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-21 18:16:49 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/8220) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/5665)
6 years, 4 months ago (2014-08-21 18:16:50 UTC) #23
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 4 months ago (2014-08-25 19:01:32 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/471243002/1
6 years, 4 months ago (2014-08-25 19:02:20 UTC) #25
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-25 19:19:09 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-25 19:22:14 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/9060) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6568)
6 years, 4 months ago (2014-08-25 19:22:15 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/471243002/40001
6 years, 3 months ago (2014-09-06 02:27:49 UTC) #31
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 04:30:32 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/471243002/40001
6 years, 3 months ago (2014-09-08 04:34:44 UTC) #35
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-08 06:35:11 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/471243002/40001
6 years, 3 months ago (2014-09-10 19:04:52 UTC) #39
commit-bot: I haz the power
Committed patchset #2 (id:40001) as dc6715944665f005396a69fa3852d0fa9b07ddff
6 years, 3 months ago (2014-09-10 20:25:50 UTC) #40
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 20:31:23 UTC) #41
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/67945b28c51b5d550ad7ea87a798a409b373346b
Cr-Commit-Position: refs/heads/master@{#294214}

Powered by Google App Engine
This is Rietveld 408576698