Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 471233003: Set RequestContextObject for PNaCl pexe fetches, to fix On-Demand update. (Closed)

Created:
6 years, 4 months ago by jvoung (off chromium)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Set RequestContextObject for PNaCl pexe fetches, to fix On-Demand update. Add more checks to test to detect that the resource type of the URL request is indeed OBJECT. Would like to get this merged to the M38 branch. BUG=401755 Committed: https://crrev.com/eeba9846656053be6dc90a6f7bf164e5695b5a22 Cr-Commit-Position: refs/heads/master@{#292470}

Patch Set 1 #

Patch Set 2 : clean up a bit #

Patch Set 3 : might as well keep old test, and keep */* check #

Patch Set 4 : try fix override #

Patch Set 5 : small change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -3 lines) Patch
M chrome/test/nacl/pnacl_header_test.h View 1 2 3 4 3 chunks +27 lines, -0 lines 0 comments Download
M chrome/test/nacl/pnacl_header_test.cc View 1 2 3 4 4 chunks +27 lines, -3 lines 0 comments Download
M components/nacl/renderer/ppb_nacl_private_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jvoung (off chromium)
6 years, 3 months ago (2014-08-25 16:34:09 UTC) #1
teravest
lgtm
6 years, 3 months ago (2014-08-25 16:36:58 UTC) #2
jvoung (off chromium)
Nick can I get an OWNERs review for chrome/test/nacl/pnacl_header_test.{cc,h} ? Thanks!
6 years, 3 months ago (2014-08-26 23:16:05 UTC) #3
Nick Bray (chromium)
LGTM
6 years, 3 months ago (2014-08-28 20:30:51 UTC) #4
jvoung (off chromium)
The CQ bit was checked by jvoung@chromium.org
6 years, 3 months ago (2014-08-28 20:42:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/471233003/80001
6 years, 3 months ago (2014-08-28 20:43:55 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001) as bfc3e122d6721ccc93f0f8b19dac4a3c2a0c947d
6 years, 3 months ago (2014-08-28 21:47:07 UTC) #7
Alpha Left Google
On 2014/08/28 21:47:07, I haz the power (commit-bot) wrote: > Committed patchset #5 (id:80001) as ...
6 years, 3 months ago (2014-08-29 00:25:29 UTC) #8
jvoung (off chromium)
A revert of this CL (patchset #5) has been created in https://codereview.chromium.org/524483002/ by jvoung@chromium.org. The ...
6 years, 3 months ago (2014-08-29 00:33:10 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:02:30 UTC) #10
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/eeba9846656053be6dc90a6f7bf164e5695b5a22
Cr-Commit-Position: refs/heads/master@{#292470}

Powered by Google App Engine
This is Rietveld 408576698