Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 471173003: Introduce HasHTMLTagName functor and use it with ElementTraversal (Closed)

Created:
6 years, 4 months ago by Inactive
Modified:
6 years, 4 months ago
Reviewers:
adamk
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink
Project:
blink
Visibility:
Public.

Description

Introduce HasHTMLTagName functor and use it with ElementTraversal Introduce HasHTMLTagName functor and use it with ElementTraversal to simplify the code a bit. R=adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180363

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -32 lines) Patch
M Source/core/html/HTMLElement.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 3 chunks +3 lines, -15 lines 0 comments Download
M Source/core/html/HTMLTableRowElement.cpp View 1 chunk +5 lines, -8 lines 0 comments Download
M Source/core/html/HTMLTableRowsCollection.cpp View 2 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
6 years, 4 months ago (2014-08-14 20:11:11 UTC) #1
adamk
lgtm with nit https://codereview.chromium.org/471173003/diff/1/Source/core/html/HTMLElement.h File Source/core/html/HTMLElement.h (right): https://codereview.chromium.org/471173003/diff/1/Source/core/html/HTMLElement.h#newcode152 Source/core/html/HTMLElement.h:152: class HasHTMLTagName { Please add a ...
6 years, 4 months ago (2014-08-14 20:15:10 UTC) #2
Inactive
https://codereview.chromium.org/471173003/diff/1/Source/core/html/HTMLElement.h File Source/core/html/HTMLElement.h (right): https://codereview.chromium.org/471173003/diff/1/Source/core/html/HTMLElement.h#newcode152 Source/core/html/HTMLElement.h:152: class HasHTMLTagName { On 2014/08/14 20:15:10, adamk wrote: > ...
6 years, 4 months ago (2014-08-14 20:21:39 UTC) #3
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-08-15 13:59:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/471173003/20001
6 years, 4 months ago (2014-08-15 14:00:06 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 14:38:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 180363

Powered by Google App Engine
This is Rietveld 408576698