Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1234)

Issue 471163006: Move HTMLInputElement method argument defaults into IDL file (Closed)

Created:
6 years, 4 months ago by Jens Widell
Modified:
6 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, arv+blink, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move HTMLInputElement method argument defaults into IDL file The stepUp()/stepDown() methods' argument should default to 1, and the setRangeText() method's selectionMode argument should default to "preserve". This matches the specification, and doesn't change behavior since these defaults were already implemented in the C++ code. BUG=258153 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180647

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M Source/core/html/HTMLInputElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLInputElement.idl View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jens Widell
PTAL
6 years, 4 months ago (2014-08-20 12:50:06 UTC) #1
haraken
LGTM Can't we remove some code from C++ for the default "preserve" value?
6 years, 4 months ago (2014-08-20 12:57:49 UTC) #2
Jens Widell
On 2014/08/20 12:57:49, haraken wrote: > LGTM > > Can't we remove some code from ...
6 years, 4 months ago (2014-08-20 13:03:30 UTC) #3
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 4 months ago (2014-08-20 13:03:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/471163006/1
6 years, 4 months ago (2014-08-20 13:05:03 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 14:03:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 180647

Powered by Google App Engine
This is Rietveld 408576698