Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 471163005: DevTools: Resource Timing: expand table in detailed view. (Closed)

Created:
6 years, 4 months ago by eustas
Modified:
6 years, 2 months ago
Reviewers:
paulirish, vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: Resource Timing: expand table in detailed view. Screenshots: Before / popover: http://picpaste.com/before1.png Before / details: http://picpaste.com/before2.png After / popover: http://picpaste.com/after1.png After / details: http://picpaste.com/after2.png BUG=403508 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183670

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -36 lines) Patch
M Source/devtools/front_end/network/NetworkPanel.js View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M Source/devtools/front_end/network/RequestTimingView.js View 1 2 3 chunks +17 lines, -31 lines 0 comments Download
M Source/devtools/front_end/networkPanel.css View 1 2 3 3 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
eustas
6 years, 4 months ago (2014-08-20 08:31:39 UTC) #1
eustas
Added screenshots.
6 years, 4 months ago (2014-08-21 12:45:06 UTC) #2
vsevik
I like that the spacing is smaller now, but I am not sure about making ...
6 years, 4 months ago (2014-08-22 15:07:02 UTC) #3
paulirish
I prefer this as opposed to the fixed width. I do think we should have ...
6 years, 3 months ago (2014-09-05 00:54:58 UTC) #4
vsevik
gtm, but please add a scale information as Paul suggests
6 years, 3 months ago (2014-09-05 05:38:13 UTC) #5
vsevik
Is this one forgotten? I meant lgtm actually
6 years, 2 months ago (2014-10-14 07:49:57 UTC) #6
eustas
On 2014/10/14 07:49:57, vsevik wrote: > Is this one forgotten? > > I meant lgtm ...
6 years, 2 months ago (2014-10-14 07:54:29 UTC) #7
vsevik
Removing myself from the reviewers for now
6 years, 2 months ago (2014-10-14 07:58:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/471163005/60001
6 years, 2 months ago (2014-10-14 12:14:08 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 13:13:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 183670

Powered by Google App Engine
This is Rietveld 408576698