Stop sorting the results of SkBBH::search().

Stop sorting the results of SkBBH::search().

We only seem to need to sort with SkQuadTree, which is not actively used by
client code.  So it's really just wasted work.  SkQuadTree is interesting, but
I'd rather disable it than slow down the production code path.

BUG=skia:2834
Committed: https://skia.googlesource.com/skia/+/0ed4e863c0b8f8a9ca8182148bf9849e5b5bf2aa

[mtklein_C, 2014-08-14 17:30:21]

Mike, this is relevant to that profile we were looking at.

[robertphillips, 2014-08-14 17:33:07]

lgtm

[mtklein, 2014-08-14 17:35:16]

The CQ bit was checked by mtklein@google.com

[mtklein, 2014-08-14 17:35:27]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2014-08-14 17:35:28]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-14 17:36:00]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/471063004/1

[mtklein, 2014-08-14 17:36:21]

On 2014/08/14 17:35:28, mtklein wrote:
> The CQ bit was checked by mailto:mtklein@google.com

FYI, I'm intentionally not setting NOTREECHECKS=true here.  This is interesting
enough to wait for >M38.

[commit-bot: I haz the power, 2014-08-18 14:57:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-18 14:57:24]

Failed to apply patch for src/core/SkRecordDraw.cpp:
While running git apply --index -p1;
  error: patch failed: src/core/SkRecordDraw.cpp:21
  error: src/core/SkRecordDraw.cpp: patch does not apply

Patch:       src/core/SkRecordDraw.cpp
Index: src/core/SkRecordDraw.cpp
diff --git a/src/core/SkRecordDraw.cpp b/src/core/SkRecordDraw.cpp
index
c9e029b8db67f11a59c9844a3128f5042931dedf..7227e3eb0375925109429787697f470a5a3d418f
100644
--- a/src/core/SkRecordDraw.cpp
+++ b/src/core/SkRecordDraw.cpp
@@ -21,12 +21,6 @@ void SkRecordDraw(const SkRecord& record,
         SkTDArray<void*> ops;
         bbh->search(devBounds, &ops);
 
-        // FIXME: QuadTree doesn't send these back in the order we inserted
them.  :(
-        // Also remove the sort in SkPictureData::getActiveOps()?
-        if (ops.count() > 0) {
-            SkTQSort(ops.begin(), ops.end() - 1, SkTCompareLT<void*>());
-        }
-
         SkRecords::Draw draw(canvas);
         for (int i = 0; i < ops.count(); i++) {
             if (NULL != callback && callback->abortDrawing()) {

[mtklein, 2014-08-18 15:05:34]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-18 15:06:23]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/471063004/20001

[commit-bot: I haz the power, 2014-08-18 15:23:23]

Committed patchset #2 (20001) as 0ed4e863c0b8f8a9ca8182148bf9849e5b5bf2aa